Add multirange support. #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Jul 22, 2023
msullivan
reviewed
Jul 22, 2023
| @@ -78,22 +78,31 @@ def is_empty(self) -> bool: | |||
| def __bool__(self): | |||
| return not self.is_empty() | |||
|
|
|||
| def __eq__(self, other): | |||
| if not isinstance(other, Range): | |||
| def __eq__(self, other) -> bool: | |||
There was a problem hiding this comment.
I don't think we should have try to have Range and MultiRange able to compare equal.
In particular, if we are going to do that, we need to have __hash__ be equal when the objects are equal, which is not worth dealing with.
There was a problem hiding this comment.
Good point about hashes equality. I'll drop the equality between Range and MultiRange.
msullivan
approved these changes
Jul 24, 2023
Add multirange codec. Adjust edgedb.Range and create edgedb.Multirange class as Python represenation of ranges and multiranges.
Co-authored-by: Yury Selivanov <yury@edgedb.com>
msullivan
pushed a commit
that referenced
this pull request
Aug 9, 2023
Add multirange codec. Adjust edgedb.Range and create edgedb.MultiRange class as Python representation of ranges and multiranges.
msullivan
added a commit
that referenced
this pull request
Aug 9, 2023
Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)
msullivan
pushed a commit
that referenced
this pull request
Aug 9, 2023
Add multirange codec. Adjust edgedb.Range and create edgedb.MultiRange class as Python representation of ranges and multiranges.
msullivan
added a commit
that referenced
this pull request
Aug 9, 2023
Changes ======= * Implement support for new type descriptor protocol (by @elprans in 47eec19 for #427) * Sync errors (by @elprans in 3bfb574 for #449) * Don't depend on exact syntax errors in tests (by @msullivan in b3ce0c6 for #451) * Fix an error in string representation of RelativeDuration. (by @vpetrovykh in 667da72 for #453) * Add multirange support. (by @vpetrovykh in 15e280e for #452)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multirange codec.
Adjust edgedb.Range and create edgedb.Multirange class as Python represenation of ranges and multiranges.