Always respect EDGEDB_CLOUD_PROFILE when connecting to cloud #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tailhook
approved these changes
May 10, 2023
fwiw you can revert edgedb/shared-client-testcases#22 to get at least one test case for |
elprans
changed the title
fantix
approved these changes
Oct 30, 2023
Cloud instances, unlike local instances, do not represent local configuration, so `EDGEDB_CLOUD_PROFILE` should always be respected when connecting to such instances regardless of how compound connection options have been specified.
elprans
added a commit
to edgedb/shared-client-testcases
that referenced
this pull request
Oct 30, 2023
This reverts commit 5f2453c. `EDGEDB_CLOUD_PROFILE` is special. See edgedb/edgedb-rust#235.
|
elprans
added a commit
to edgedb/shared-client-testcases
that referenced
this pull request
Oct 30, 2023
This reverts commit 5f2453c. `EDGEDB_CLOUD_PROFILE` is special. See edgedb/edgedb-rust#235.
fantix
approved these changes
Oct 30, 2023
elprans
added a commit
to edgedb/edgedb-cli
that referenced
this pull request
Oct 30, 2023
elprans
added a commit
to edgedb/edgedb-cli
that referenced
this pull request
Oct 30, 2023
elprans
added a commit
to edgedb/edgedb-cli
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud instances, unlike local instances, do not represent local
configuration, so
EDGEDB_CLOUD_PROFILEshould always be respectedwhen connecting to such instances regardless of how compound
connection options have been specified.