Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): create image req #291

Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat(docker): create image req #291

merged 7 commits into from
Oct 18, 2024

Conversation

joshuachp
Copy link
Collaborator

Closes #277

@joshuachp joshuachp force-pushed the feature/create-image-req branch 2 times, most recently from 5bb43b9 to 6ba8989 Compare October 26, 2023 13:07
@joshuachp joshuachp force-pushed the feature/create-image-req branch 2 times, most recently from 32a72bd to 49df978 Compare November 2, 2023 11:33
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.12565% with 122 lines in your changes missing coverage. Please review.

Project coverage is 58.2%. Comparing base (ca617a9) to head (f0e1b1e).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ehog-device-runtime-containers/src/docker/image.rs 33.9% 68 Missing ⚠️
...gehog-device-runtime-containers/src/service/mod.rs 17.9% 32 Missing ⚠️
...-device-runtime-containers/src/service/resource.rs 11.7% 15 Missing ⚠️
...gehog-device-runtime-containers/src/store/image.rs 50.0% 4 Missing ⚠️
...hog-device-runtime-containers/src/service/state.rs 0.0% 2 Missing ⚠️
...ehog-device-runtime-containers/src/service/node.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...dgehog-device-runtime-containers/src/docker/mod.rs 60.0% <ø> (+33.3%) ⬆️
...-device-runtime-containers/src/properties/image.rs 100.0% <100.0%> (ø)
...og-device-runtime-containers/src/properties/mod.rs 62.5% <ø> (+62.5%) ⬆️
...og-device-runtime-containers/src/requests/image.rs 100.0% <100.0%> (ø)
...ehog-device-runtime-containers/src/requests/mod.rs 80.0% <100.0%> (+80.0%) ⬆️
...evice-runtime-containers/src/service/collection.rs 42.5% <ø> (+36.1%) ⬆️
edgehog-device-runtime-containers/src/store/mod.rs 87.5% <100.0%> (+46.0%) ⬆️
...ehog-device-runtime-containers/src/service/node.rs 69.2% <0.0%> (+38.4%) ⬆️
...hog-device-runtime-containers/src/service/state.rs 4.1% <0.0%> (+0.1%) ⬆️
...gehog-device-runtime-containers/src/store/image.rs 50.0% <50.0%> (ø)
... and 3 more

harlem88
harlem88 requested changes Nov 2, 2023
View reviewed changes
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
@joshuachp joshuachp force-pushed the feature/create-image-req branch 4 times, most recently from 0c79e64 to a5fef50 Compare December 20, 2023 15:11
@joshuachp joshuachp changed the base branch from main to feature-docker September 30, 2024 08:44
@joshuachp joshuachp changed the title Feature/create image req feat(docker): create image req Sep 30, 2024
rgallor
rgallor suggested changes Sep 30, 2024
View reviewed changes
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
rgallor
rgallor suggested changes Oct 3, 2024
View reviewed changes
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/properties.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
@joshuachp joshuachp force-pushed the feature/create-image-req branch 3 times, most recently from 123a014 to c860b2d Compare October 3, 2024 13:44
@joshuachp joshuachp requested a review from rgallor October 3, 2024 13:45
harlem88
harlem88 requested changes Oct 3, 2024
View reviewed changes
edgehog-device-runtime-docker/src/properties.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/request.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
lucaato
lucaato reviewed Oct 15, 2024
View reviewed changes
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/image.rs Outdated Show resolved Hide resolved
edgehog-device-runtime-docker/src/service.rs Outdated Show resolved Hide resolved
@joshuachp joshuachp force-pushed the feature/create-image-req branch 7 times, most recently from 57ffac2 to 87664a7 Compare October 16, 2024 15:06
@joshuachp joshuachp changed the base branch from feature-docker to main October 16, 2024 16:04
@joshuachp joshuachp force-pushed the feature/create-image-req branch 2 times, most recently from 8ed3362 to f530727 Compare October 17, 2024 13:43
@joshuachp
feat(docker): add image structure
bcd2f90 
Create the image that can be pulled from a registry, with optionally
authentication, and remove it for cleanup.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
feat(docker): add available images property
8405c49 
Add the AvailableImage property, and mock the client to test the store
call.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
feat(docker): implement store for images
6f26622 
Add an image state struct to have a consistent stabilization of an image
to persistent storage.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
feat(request): add CreateImageRequest structure
37cfa10 
Add the request and NodeType for the image.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
feat(container): handle the image resource request
d7aad92 
Create the image and store it in the state file.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
chore(test): add on create image req test
a6a01f5 
Test the reception of a create image request for the containers.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@joshuachp
chore(test): add test to the image conversion
f0e1b1e 
Make the code clearer and test the conversion from CreateImage to Image.

Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
@harlem88 harlem88 merged commit 40edd44 into edgehog-device-manager:main Oct 18, 2024
14 of 15 checks passed
@joshuachp joshuachp deleted the feature/create-image-req branch October 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgallor rgallor rgallor approved these changes

@lucaato lucaato lucaato approved these changes

@harlem88 harlem88 harlem88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docker] Create image request
4 participants
@joshuachp @harlem88 @lucaato @rgallor