cli: add option to automatically merge kubeconfig file on init #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datosh
reviewed
Feb 3, 2023
datosh
approved these changes
Feb 8, 2023
daniel-weisse
force-pushed
the
feat/cli/kubeconfig-naming
branch
from
fbdc73b
to
785cabf
Compare
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
feat/cli/config-merging
branch
from
ff2ecf1
to
627b053
Compare
❌ Deploy Preview for constellation-docs failed.
|
msanft
pushed a commit
that referenced
this pull request
Feb 13, 2023
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
msanft
pushed a commit
that referenced
this pull request
Feb 13, 2023
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add
--merge-kubeconfigflag toconstellation init.If set, automatically merges the config generated by
initinto the default configuration in$HOME/.kube/configand sets it as the current context.Users are then able to connect to the cluster without having to do any extra setup.
If the
KUBECONFIGenv variable is set, the new config is still merged into the default config, but we cant reliably tell ifkubectlwill load this config, so a warning is printed in this case telling the user they might need to unset theKUBECONFIGenv varChecklist