cli: fix iam rollback #1148
Merged
cli: fix iam rollback #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
katexochen
reviewed
Feb 6, 2023
daniel-weisse
approved these changes
Feb 6, 2023
msanft
added a commit
that referenced
this pull request
Feb 13, 2023
* AB#2897 rename DestroyCluster * #AB2897 error if terraform dir exists * AB#2897 reword DestroyResources
msanft
added a commit
that referenced
this pull request
Feb 13, 2023
* AB#2897 rename DestroyCluster * #AB2897 error if terraform dir exists * AB#2897 reword DestroyResources
derpsteb
pushed a commit
that referenced
this pull request
Feb 22, 2023
* AB#2897 rename DestroyCluster * #AB2897 error if terraform dir exists * AB#2897 reword DestroyResources
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
iam createcommand and if it exists, do not continue with executionDestroyClustertoDestroyResourcesas it can also destroy IAM resourcesAdditional info
iam createcommand is executed twice in a row, the second execution would error because the Terraform state dir already exists. On this error, it would also rollback the existing directory which deletes the Terraform state of a previous execution of the commandChecklist