Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --kubernetes flag to config generate #1226

Merged
merged 1 commit into from
Feb 21, 2023
Merged

cli: add --kubernetes flag to config generate #1226

merged 1 commit into from
Feb 21, 2023

Conversation

derpsteb
Copy link
Member

Proposed change(s)

  • This flag can be used to specify a Kubernetes version in format MAJOR.MINOR and let the CLI extend the
    value with the patch version.

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@derpsteb
cli: add --kubernetes flag
ef3539d 
The flag can be used to specify a Kubernetes version
in format MAJOR.MINOR and let the CLI extend the
value with the patch version.
@derpsteb derpsteb added the feature This introduces new functionality label Feb 20, 2023
@netlify
Copy link

netlify bot commented Feb 20, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit ef3539d
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63f36aa9d6b812000838a0c2

datosh
datosh approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@datosh datosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, would it make sense to add the same flag to iam create --generate-config ?

@derpsteb
Copy link
Member Author

Yes. Added a ticket to track this.

@derpsteb derpsteb merged commit da7a870 into main Feb 21, 2023
@derpsteb derpsteb deleted the feat/k8sversion-flag branch February 21, 2023 13:05
msanft pushed a commit that referenced this pull request Feb 21, 2023
@derpsteb @msanft
cli: add --kubernetes flag (#1226)
8a3bc1a 
The flag can be used to specify a Kubernetes version
in format MAJOR.MINOR and let the CLI extend the
value with the patch version.
msanft pushed a commit that referenced this pull request Feb 22, 2023
@derpsteb @msanft
cli: add --kubernetes flag (#1226)
a62a429 
The flag can be used to specify a Kubernetes version
in format MAJOR.MINOR and let the CLI extend the
value with the patch version.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datosh datosh datosh approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derpsteb @datosh