Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam: assign uami role to base resource group #1247

Merged
merged 2 commits into from
Feb 22, 2023
Merged

iam: assign uami role to base resource group #1247

merged 2 commits into from
Feb 22, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Feb 21, 2023

Proposed change(s)

  • Assign role at the base resource group and not the iam resource group

This bug was introduced in b864826

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added the bug fix Fixing a bug label Feb 21, 2023
@3u13r 3u13r added this to the v2.6.0 milestone Feb 21, 2023
@3u13r 3u13r requested a review from msanft February 21, 2023 14:57
@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit e18d8db
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/63f50b4baee3540008705e77
😎 Deploy Preview https://deploy-preview-1247--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thomasten thomasten added the needs backport This PR needs to be backported to a previous release label Feb 21, 2023
thomasten
thomasten approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@3u13r
Copy link
Member Author

3u13r commented Feb 21, 2023

now the autoscaler also works

@3u13r 3u13r merged commit ce09b9d into main Feb 22, 2023
@3u13r 3u13r deleted the fix/iam/azure/UAMIRoleAssignment branch February 22, 2023 08:29
msanft pushed a commit that referenced this pull request Feb 22, 2023
@3u13r @msanft
iam: assign uami role to base resource group (#1247)
3ec9384 
* iam: assign uami role to base resource group

* fixup: also change app registration
msanft pushed a commit that referenced this pull request Feb 22, 2023
@3u13r @msanft
iam: assign uami role to base resource group (#1247)
83f9ad6 
* iam: assign uami role to base resource group

* fixup: also change app registration
derpsteb pushed a commit that referenced this pull request Feb 22, 2023
@3u13r @derpsteb
iam: assign uami role to base resource group (#1247)
6ee9272 
* iam: assign uami role to base resource group

* fixup: also change app registration
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@thomasten thomasten thomasten approved these changes

@msanft msanft Awaiting requested review from msanft

Assignees
No one assigned
Labels
bug fix Fixing a bug needs backport This PR needs to be backported to a previous release
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@3u13r @katexochen @thomasten