Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade github.com/aws/aws-sdk-go-v2/... #2807

Closed
wants to merge 2 commits into from
Closed

deps: upgrade github.com/aws/aws-sdk-go-v2/... #2807

wants to merge 2 commits into from

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jan 9, 2024 •
edited
Loading

Context

The attestationconfig API test is currently broken on main, because the AWS SDK returns errors along the lines of not found, ResolveEndpointV2: https://github.com/edgelesssys/constellation/actions/runs/7450533078. According to aws/aws-sdk-go-v2#2370, the problem is an incompatibility of AWS SDK subcomponents and the solutions is to upgrade all of them.

This went unnoticed because the workflow is not invoked on dependency updates, and theinternal/api code has not been touched recently.

Proposed change(s)

  • Upgrade AWS SDK with go get -u github.com/aws/aws-sdk-go-v2/....
  • Adapt to struct type changes in the libraries (versions don't seem to be semantic ☹️ ).
  • Add go.mod to the workflow triggers so that we detect similar problems on the culprit PRs.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added dependencies Pull requests that update a dependency file no changelog Change won't be listed in release changelog labels Jan 9, 2024
@burgerdev burgerdev added this to the v2.15.0 milestone Jan 9, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 16afad1
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/659d09f052e9a700081d7911

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Coverage report

Package Old New Trend
hack/bazel-deps-mirror/internal/mirror 80.20% 80.20% ↔️
internal/api/attestationconfigapi/cli [no test files] [no test files] 🚧
internal/api/client [no test files] [no test files] 🚧

3u13r
3u13r reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could've also tried opening the renovate PR for "deps: update AWS SDK "

internal/api/attestationconfigapi/cli/azure.go Show resolved Hide resolved
@burgerdev
Copy link
Contributor Author

Closing in favour of #2809.

@burgerdev burgerdev closed this Jan 9, 2024
@burgerdev burgerdev deleted the burgerdev/attestationconfigapi-test branch January 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3u13r 3u13r 3u13r left review comments

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

@malt3 malt3 Awaiting requested review from malt3

@daniel-weisse daniel-weisse Awaiting requested review from daniel-weisse daniel-weisse is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @3u13r