operators: ignore node deletion errors on absence #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
Comment on lines
222
to
227
| func isInstanceNotFoundError(err error) bool { | ||
| if err == nil { | ||
| return false | ||
| } | ||
| return strings.Contains(err.Error(), "Instance Id not found") | ||
| } |
There was a problem hiding this comment.
Suggested change
| func isInstanceNotFoundError(err error) bool { | |
| if err == nil { | |
| return false | |
| } | |
| return strings.Contains(err.Error(), "Instance Id not found") | |
| } | |
| func isInstanceNotFoundError(err error) bool { | |
| var respErr *awshttp.ResponseError // using "awshttp" for package github.com/aws/aws-sdk-go-v2/aws/transport/http | |
| return errors.As(err, &respErr) && respErr.HTTPStatusCode() == http.StatusNotFound | |
| } | |
From https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md#error-handling
Did not tests this, but if it works it would be preferable over string comparisons.
There was a problem hiding this comment.
That would be preferable indeed, but AWS does not return 404s in that case, but 400s. I meant to also link to the logs but forgot - fixed that now (see above). I would not want to infer nonexistence from a 400, because that might hide other failure conditions, so I'm back at string comparison :/
<ErrorResponse xmlns="http://autoscaling.amazonaws.com/doc/2011-01-01/">
<Error>
<Type>Sender</Type>
<Code>ValidationError</Code>
<Message>Instance Id not found - No managed instance found for instance ID: i-061c63c5eb45f0416</Message>
</Error>
<RequestId>702f44ea-6d55-480b-8dfa-3da9e62f1634</RequestId>
</ErrorResponse>
Coverage report
|
malt3
approved these changes
May 21, 2024
daniel-weisse
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If a node deletion operation fails transiently after the instance was deleted at the CSP, we need to ensure that the retry succeeds, even if the instance we attempt to delete is already gone at the CSP.
Example operator logs: https://gist.github.com/burgerdev/c80de86ae44552a383364ef031243a41
Proposed change(s)
SkipInstancesOnValidationError, which is designed for this use case.Additional info
Checklist