Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix GCP CCM findvers.sh script #3178

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jun 19, 2024

Context

Due to a small mistake in the script, it only ever worked correctly if there were 0 or 1 images to build. Last week saw 3 new tags published on the repo, which triggered the failure: https://github.com/edgelesssys/constellation/actions/runs/9582767025/job/26422530403.

Proposed change(s)

  • Print one tag per line before handling with jq.

Checklist

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Jun 19, 2024
@burgerdev burgerdev added this to the v2.17.0 milestone Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 12dbe2c
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6672e4835638870008c48b3f

Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@burgerdev burgerdev merged commit 132d540 into main Jun 19, 2024
17 checks passed
@burgerdev burgerdev deleted the burgerdev/gcp-ccm-script branch June 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants