Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugd: reset unit failed status before restarting #3183

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Jun 20, 2024

Context

On debug images, our bootstrapper and upgrade-agent systemd units continuously fail until the binaries are uploaded using cdbg deploy.
Once this is done, the debugd issues a systemctl restart command to those units.
Under some circumstances, this restart can fall into the timeout period from our units being rate limited in restarting by systemd.
We can use systemctl reset-failed to reset the failed counter and by this way bypass the timeout.

See https://bugzilla.redhat.com/show_bug.cgi?id=1016548 for some more details about the issue.
See the man page for systemctl reset-failed.

Proposed change(s)

  • Run systemctl reset-failed before restarting a unit in debugd

Related issue

Additional info

  • debug image to test: ref/fix-debugd-unit-restarting/stream/debug/v2.17.0-pre.0.20240620090724-9385e634a613

Checklist

  • Run the E2E tests that are relevant to this PR's changes

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 9385e63
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6673d8b5fb247d0008a8baf0

@daniel-weisse daniel-weisse marked this pull request as ready for review June 20, 2024 08:27
@daniel-weisse daniel-weisse merged commit c1e4da3 into main Jun 20, 2024
19 of 20 checks passed
@daniel-weisse daniel-weisse deleted the fix/debugd/unit-restarting branch June 20, 2024 09:22
@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants