debugd: daemonize logstash containers #3216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a race condition between starting the logcollection pods and waiting for them to become ready. If the
cmd.Start()
is not fast enough to create the container,podman wait
will error out because it does not know about the container.Proposed change(s)
Note that the logs of the podman containers either end up in OpenSearch (if everything is fine), or are not accessible (if logcollection is broken). Either way, the outcome is the same as before this change.
Additional info
Checklist