Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugd: daemonize logstash containers #3216

Merged
merged 2 commits into from
Jun 28, 2024
Merged

debugd: daemonize logstash containers #3216

merged 2 commits into from
Jun 28, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jun 28, 2024

Context

There is a race condition between starting the logcollection pods and waiting for them to become ready. If the cmd.Start() is not fast enough to create the container, podman wait will error out because it does not know about the container.

Proposed change(s)

  • Daemonize the logcollection containers and wait for the podman command to run through.
  • Add a restart policy to ensure they keep running (or crash-looping).

Note that the logs of the podman containers either end up in OpenSearch (if everything is fine), or are not accessible (if logcollection is broken). Either way, the outcome is the same as before this change.

Additional info

Checklist

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Jun 28, 2024
@burgerdev burgerdev added this to the v2.17.0 milestone Jun 28, 2024
@burgerdev burgerdev requested a review from msanft June 28, 2024 12:32
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 5dc7c7f
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/667ead6311bc1d000813aa0e

Copy link
Contributor

Coverage report

Package Old New Trend
debugd/internal/debugd/logcollector 6.10% 6.10% 🚧

@burgerdev burgerdev merged commit ab94456 into main Jun 28, 2024
18 checks passed
@burgerdev burgerdev deleted the burgerdev/podman branch June 28, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants