openstack: Fix a crash in the bootstrapper during node join discovery

[3u13r]

Context

The bootstrapper still likes to query any nodes in addition to the LB endpoint when searching for join endpoints.

Openstack has a catalog discovery feature that gets URL endpoints during authentication (see: https://github.com/jtopjian/gophercloud/blob/master/openstack/endpoint_location.go#L63). Since we did not set the region we received more endpoints than expected and some even invalid ones.

Proposed change(s)

• Passthrough openstack region name via IMDS to instance to use it in the cloud API client.

Checklist

• Add labels (e.g., for changelog category)
• Is PR title adequate for changelog?
• Link to Milestone

[netlify]

✅ Deploy Preview for constellation-docs canceled.

Name	Link
🔨 Latest commit	09875af
🔍 Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/66f2b10e0a93dd00070fd0a5

[github-actions]

Coverage report

Package	Old	New	Trend
internal/cloud/openstack	86.60%	84.40%	↘️

[burgerdev]

I don't see where the actual crash is being fixed or handled - the bootstrapper should be able to join the cluster even if the metadata API does not return or returns wrong addresses, shouldn't it?

[3u13r]

I also not remember the actual crash location. I'll spin up a cluster to document this more thoroughly.

[burgerdev]

I tested the branch and the change lgtm. Let's follow up on the resilience topic.