constellation-node-operator: don't bail out on listing errors #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
operators/constellation-node-operator/internal/cloud/gcp/client/scalinggroup.go
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
from
f649407
to
39117d1
Compare
3u13r
requested changes
Dec 3, 2024
operators/constellation-node-operator/internal/cloud/gcp/client/scalinggroup.go
Outdated
Show resolved
Hide resolved
operators/constellation-node-operator/internal/cloud/gcp/client/scalinggroup.go
Outdated
Show resolved
Hide resolved
operators/constellation-node-operator/internal/cloud/gcp/client/scalinggroup.go
Outdated
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
from
39117d1
to
188b474
Compare
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
2 times, most recently
from
37ddceb
to
1a1001d
Compare
operators/constellation-node-operator/internal/cloud/gcp/client/scalinggroup.go
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
from
1a1001d
to
8776aab
Compare
daniel-weisse
approved these changes
Dec 3, 2024
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
from
8776aab
to
71532b1
Compare
If the GCP project has scaling groups for which our checks can't be performed (which is the case for regional scaling groups, as they "don't exist" for the operator, if deployed in another region) . In that case, we should not bail out directly but go on with the next group. An error should only be thrown if there are no matching groups at all.
msanft
force-pushed
the
msanft/operator/gcp-scaling-groups
branch
from
71532b1
to
c71defe
Compare
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If the GCP project has scaling groups for which our checks can't be performed (which is the case for regional scaling groups, as they "don't exist" for the operator, if deployed in another region) . In that case, we should not bail out directly but go on with the next group. An error should only be thrown if there are no matching groups at all.
Proposed change(s)
Checklist