Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set proper transform flag for Set command #1578

Merged
merged 1 commit into from
May 16, 2024

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented May 15, 2024

close #1553

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

close edgexfoundry#1553

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
@cloudxxx8
Copy link
Member Author

@rst2071 @muehle28
could you please review or verify this PR?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.28%. Comparing base (decf7a4) to head (22d8ecf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1578   +/-   ##
=======================================
  Coverage   47.28%   47.28%           
=======================================
  Files          30       30           
  Lines        2870     2870           
=======================================
  Hits         1357     1357           
  Misses       1411     1411           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rst2071 rst2071 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@lindseysimple lindseysimple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindseysimple lindseysimple merged commit 97b36af into edgexfoundry:main May 16, 2024
3 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-1553 branch June 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device service PUT handling: wrong value published on MessageBus when DataTransform is used
4 participants