Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use atomic operation to provision profile #1587

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Jun 24, 2024

Fix #1586

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Fix edgexfoundry#1586

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
@cloudxxx8 cloudxxx8 requested a review from FelixTing June 24, 2024 13:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.92%. Comparing base (911624c) to head (36fb107).

Files Patch % Lines
internal/cache/profiles.go 0.00% 7 Missing ⚠️
internal/provision/profiles.go 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   47.28%   46.92%   -0.37%     
==========================================
  Files          30       30              
  Lines        2870     2875       +5     
==========================================
- Hits         1357     1349       -8     
- Misses       1411     1421      +10     
- Partials      102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FelixTing FelixTing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit f5f74a4 into edgexfoundry:main Jun 25, 2024
3 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-1586 branch June 25, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceProfile provision state might be wrong
3 participants