Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

test(snap): add CI workflow #439

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Apr 14, 2022

The workflow added here will activate only after it has been merged into the main. In the meantime, MonicaisHer#1 that is against the fork can be taken as a reference.

Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-cli/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Add CI workflow MonicaisHer/edgex-cli#1
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer force-pushed the EDGEX-416-Add-CI-workflow branch from 3f8c922 to 7c3d353 Compare April 14, 2022 07:55
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer force-pushed the EDGEX-416-Add-CI-workflow branch from 88d4f35 to d8b3c9b Compare April 14, 2022 09:49
@MonicaisHer MonicaisHer marked this pull request as draft April 14, 2022 09:50
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer marked this pull request as ready for review April 19, 2022 09:11
@MonicaisHer MonicaisHer requested a review from farshidtz April 19, 2022 09:11
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Please modify the PR title: test(snap): add CI workflow local

Someone with rights should kindly squash and merge.

@MonicaisHer MonicaisHer changed the title test(snap): add CI workflow local test(snap): add CI workflow Apr 19, 2022
@MonicaisHer MonicaisHer requested a review from jpwhitemn April 20, 2022 08:46
@jpwhitemn jpwhitemn merged commit 72600b4 into edgexfoundry:main Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants