feat: Create UCR for using URIs to load files #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
bnevis-i
previously approved these changes
Jan 18, 2023
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
bnevis-i
previously approved these changes
Jan 18, 2023
farshidtz
previously approved these changes
Jan 19, 2023
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from farshidtz and bnevis-i
via
f91ae13
farshidtz
previously approved these changes
Jan 19, 2023
bnevis-i
previously approved these changes
Jan 19, 2023
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from bnevis-i and farshidtz
via
f0005c6
bnevis-i
approved these changes
Jan 25, 2023
farshidtz
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
I think this mechanism is a quick workaround which simplifies the distribution of static configurations across multiple deployments of the EdgeX stack.
Nevertheless, I believe that such functionality should be generally handed off to the Config Provider, or rather, a federation of Config Providers. This is not easily possible right now because device configurations are maintained in Core Metadata.
This UCR does make strong assumptions about how a functionality should be realized, rather than just laying out the use case and application requirements.
edgex-jenkins
added a commit
that referenced
this pull request
Jan 25, 2023
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonard Goodell leonard.goodell@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements: