Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(snap): Move usage instructions to docs #519

Merged
merged 1 commit into from
May 6, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented May 4, 2022

Usage instructions are being moved to docs; see edgexfoundry/edgex-docs#751.
The snap/README has been updated to include development docs only.

Depends on:

Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz marked this pull request as draft May 4, 2022 13:14
@MonicaisHer MonicaisHer self-requested a review May 4, 2022 13:15
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you, looks good.

@badboy-huaqiao badboy-huaqiao marked this pull request as ready for review May 5, 2022 01:24
Copy link
Member

@badboy-huaqiao badboy-huaqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz marked this pull request as draft May 5, 2022 14:00
@MonicaisHer MonicaisHer marked this pull request as ready for review May 6, 2022 13:14
@MonicaisHer MonicaisHer merged commit 6924cde into edgexfoundry:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants