-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update go-mod-bootstrap dep #771
Conversation
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also push the go.sum
i can't explain it, but even after I run go mod tidy, the go sum file doesn't change. i even deleted go.sum, then regenerated it with go mod tidy and the file is the same. |
I ecnountered the same issue, but it works after I manually upgrade other direct modules |
Thanks. I'll close this pr. The UI isn't vital, but might as well keep it up to date |
I just realized the problem is from this line Line 140 in a8d6b14
|
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
hahaha oooops. how'd that sneak in and get through the review process? :) I pushed the change if you want to keep my pr (or yours, whichever) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)