Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go-mod-bootstrap dep #771

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

dovholuknf
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also push the go.sum

@dovholuknf
Copy link
Contributor Author

i can't explain it, but even after I run go mod tidy, the go sum file doesn't change. i even deleted go.sum, then regenerated it with go mod tidy and the file is the same.

@cloudxxx8
Copy link
Member

I ecnountered the same issue, but it works after I manually upgrade other direct modules
Please review my PR here
#772

@dovholuknf
Copy link
Contributor Author

Thanks. I'll close this pr. The UI isn't vital, but might as well keep it up to date

@dovholuknf dovholuknf closed this Jul 19, 2024
@cloudxxx8
Copy link
Member

I just realized the problem is from this line

replace github.com/edgexfoundry/go-mod-bootstrap/v3 => github.com/edgexfoundry/go-mod-bootstrap/v3 v3.2.0-dev.27

Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
@dovholuknf
Copy link
Contributor Author

hahaha oooops. how'd that sneak in and get through the review process? :) I pushed the change if you want to keep my pr (or yours, whichever)

@dovholuknf dovholuknf reopened this Jul 19, 2024
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a97f609 into edgexfoundry:main Jul 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants