-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add openziti bind support to ui #775
feat: add openziti bind support to ui #775
Conversation
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
ozUrl := b.cfg.Service.SecurityOptions["OpenZitiController"] | ||
var zctx ziti.Context | ||
var authErr error | ||
if os.Getenv("SERVICE_SECURITYOPTIONS_OPENZITIAUTHMETHOD") == "identity" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should eventually probably be replaced by using the standard configuration options but these two keys need to be added to the "default" and I can't remember where that is :)
@@ -125,8 +133,64 @@ func (b *HttpServer) BootstrapHandler( | |||
b.isRunning = false | |||
}() | |||
|
|||
var ln net.Listener | |||
listenMode := strings.ToLower(b.cfg.Service.SecurityOptions[bscfg.SecurityModeKey]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this functionality should also be moved to go-mod-bootstrap
or some other common place. this code is largely simlar to code in app-functions-sdk-go/internal/webserver/server.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we should do it when we have a chance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR allows the UI to be OpenZiti enabled for binding services as well
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)