feat: add openziti bind support to ui #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
dovholuknf
commented
Jul 23, 2024
| ozUrl := b.cfg.Service.SecurityOptions["OpenZitiController"] | ||
| var zctx ziti.Context | ||
| var authErr error | ||
| if os.Getenv("SERVICE_SECURITYOPTIONS_OPENZITIAUTHMETHOD") == "identity" { |
There was a problem hiding this comment.
this should eventually probably be replaced by using the standard configuration options but these two keys need to be added to the "default" and I can't remember where that is :)
dovholuknf
commented
Jul 23, 2024
| @@ -125,8 +133,64 @@ func (b *HttpServer) BootstrapHandler( | |||
| b.isRunning = false | |||
| }() | |||
|
|
|||
| var ln net.Listener | |||
| listenMode := strings.ToLower(b.cfg.Service.SecurityOptions[bscfg.SecurityModeKey]) | |||
There was a problem hiding this comment.
all this functionality should also be moved to go-mod-bootstrap or some other common place. this code is largely simlar to code in app-functions-sdk-go/internal/webserver/server.go
There was a problem hiding this comment.
yes, we should do it when we have a chance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the UI to be OpenZiti enabled for binding services as well
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)