Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bigint for all non-uuid primary keys #1067

Closed
3 tasks done
Mr0grog opened this issue Jan 20, 2023 · 0 comments · Fixed by #1088
Closed
3 tasks done

Use bigint for all non-uuid primary keys #1067

Mr0grog opened this issue Jan 20, 2023 · 0 comments · Fixed by #1088

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Jan 20, 2023 •
edited
Loading

We have some models with UUID primary keys and some that use int. We should have used bigint for both, but that ship has long since sailed on the ones with UUID keys. We should still upgrade the int keys to bigint, though.

  • imports
  • invitations
  • users
@Mr0grog Mr0grog mentioned this issue Jan 24, 2023
Closed
37 tasks
Mr0grog added a commit that referenced this issue Feb 9, 2023
@Mr0grog
Change int primary keys to bigint
3869a6e 
Integer primary keys can cause problems over time on big tables, and in general it's just better practice to use bigints instead. Some of our larger tables use UUIDs instead of ints, so this only upgrades the tables that used ints. (Practically speaking, none of these tables are really *likely* to overflow their primary key sequence, but better safe than sorry here, especially with technical maintainers offboarding.)

Fixes #1067.
Mr0grog added a commit that referenced this issue Feb 9, 2023
@Mr0grog
Change int primary keys to bigint
716f534 
Integer primary keys can cause problems over time on big tables, and in general it's just better practice to use bigints instead. Some of our larger tables use UUIDs instead of ints, so this only upgrades the tables that used ints. (Practically speaking, none of these tables are really *likely* to overflow their primary key sequence, but better safe than sorry here, especially with technical maintainers offboarding.)

Fixes #1067.
@Mr0grog Mr0grog mentioned this issue Feb 9, 2023
Merged
Mr0grog added a commit that referenced this issue Feb 9, 2023
@Mr0grog
Change int primary keys to bigint (#1088)
d12fa29 
Integer primary keys can cause problems over time on big tables, and in general it's just better practice to use bigints instead. Some of our larger tables use UUIDs instead of ints, so this only upgrades the tables that used ints. (Practically speaking, none of these tables are really *likely* to overflow their primary key sequence, but better safe than sorry here, especially with technical maintainers offboarding.)

Fixes #1067.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change int primary keys to bigint edgi-govdata-archiving/web-monitoring-db
1 participant
@Mr0grog