correct :max_body_length documentation and spec #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also include an integration test? We can use https://github.com/edgurgel/httpoison/blob/master/test/httpoison_test.exs |
|
I'm busy tonight, but i'll see if i can write a quick test tomorrow |
|
No problem, @pedep ! I will probably have some free time this weekend. I can write the test if you couldn't find time 👍 |
|
@edgurgel I've dug a bit, and i think this spec explains & covers the expected behavior of our usage of |
|
@pedep, fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, but it seems #354's assumed behaviour was wrong.
I assumed the
:max_lengthinbody/2would error, because, what would an incomplete response be worth, but it seems it simply returns the body up until:max_length.I have corrected the doc and spec to reflect this.
I will submit another PR implementing this behaviour in HTTPoison, since my original intention was to protect against too much data being returned with an error.
Sorry for the mistake @edgurgel