Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: twitter (support both x.com and twitter.com) urls #127

Merged
merged 4 commits into from
May 17, 2024
Merged

fix: twitter (support both x.com and twitter.com) urls #127

merged 4 commits into from
May 17, 2024

Conversation

hortopan
Copy link
Contributor

Twitter.com now uses x.com in main urls.

neSpecc
neSpecc reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please add a corresponded testcase(s)

And increment a patch version

@neSpecc
Copy link
Contributor

neSpecc commented May 17, 2024

Tests are failed, could you check?

@hortopan
Copy link
Contributor Author

Tests are failed, could you check?

Sorry about that. I was sloppy with the regex in the initial commit.

neSpecc
neSpecc requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock should not be changed here

@neSpecc neSpecc merged commit e3922a4 into editor-js:master May 17, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hortopan @neSpecc