Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (fixing an issue): migrate to typescript #108

Merged
merged 4 commits into from
Jun 15, 2024
Merged

fix (fixing an issue): migrate to typescript #108

merged 4 commits into from
Jun 15, 2024

Conversation

dependentmadani
Copy link
Contributor

Hello,
I need a review of code for fixing issue #106. Thanks

neSpecc
neSpecc reviewed Jun 13, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@dependentmadani
Copy link
Contributor Author

Changes made:

  • Remove the package-lock.json.
  • Use vite-plugin-dts instead of rollup plugin.
  • Add Jsdocs to each property.
  • Export the HeaderData interface.
  • Move object type into a CSS getter.
  • Import necessary interfaces from editorjs.
  • Remove the unused props from tsconfig file.

neSpecc
neSpecc previously approved these changes Jun 15, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@dependentmadani
Copy link
Contributor Author

Change made:

  • export the HeaderConfig interface.

@neSpecc neSpecc merged commit 477853c into editor-js:master Jun 15, 2024
This was referenced Jun 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dependentmadani @neSpecc