Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: editorconfig-checker-disable-next-line #363

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat: editorconfig-checker-disable-next-line #363

merged 5 commits into from
Sep 4, 2024

Conversation

ccoVeille
Copy link
Contributor

  • fix: broken test
  • chore: fix typos and style in documentation
  • feat: add editorconfig-checker-next-line

Fixes #180

@ccoVeille
Copy link
Contributor Author

please review @theoludwig @mstruebing

cc @andreineculau if you are still interested as you created the issue #180 3 years ago
cc @BorzdeG because we talked about it with caarlos0/env#327

@ccoVeille ccoVeille mentioned this pull request Aug 23, 2024
Closed
@mstruebing
Copy link
Member

Amazing 🚀
I will probably review this PR this weekend.

@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (d6c17be) to head (6bc73f9).
Report is 36 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   84.89%   85.61%   +0.71%     
==========================================
  Files           8        8              
  Lines         695      549     -146     
==========================================
- Hits          590      470     -120     
+ Misses         81       55      -26     
  Partials       24       24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

theoludwig
theoludwig reviewed Aug 24, 2024
View reviewed changes
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks mostly good to me. 👍

testfiles/disabled-line.txt Show resolved Hide resolved
@ccoVeille
Copy link
Contributor Author

Are we good then?

I wasn't sure with the last messages from @theoludwig

I replied here

@theoludwig theoludwig mentioned this pull request Aug 30, 2024
Closed
@theoludwig
Copy link
Member

Are we good then?

I wasn't sure with the last messages from @theoludwig

@ccoVeille To me it looks good, ready to merge as is, without further changes.
BUT I'm really only reviewing general logic and unit tests, and if the behavior matches with expectations (as a heavy user of editorconfig-checker myself).
I'm not coding in Go (actually never used it), and don't own this codebase or did much in it, so I can't and should not have the confidence to review implementation details.

For more context about the maintenance of editorconfig-checker, I've created an issue: #364

@theoludwig theoludwig added this to the v3.1.0 milestone Aug 30, 2024
@ccoVeille
Copy link
Contributor Author

OK, thanks. Feel free to merge whenever you want then

ccoVeille and others added 2 commits August 31, 2024 09:43
@theoludwig theoludwig changed the title editorconfig checker disable next line feat: editorconfig-checker-disable-next-line Sep 4, 2024
@theoludwig theoludwig merged commit 6116ec6 into editorconfig-checker:main Sep 4, 2024
5 checks passed
@ccoVeille ccoVeille deleted the editorconfig-checker-disable-next-line branch September 4, 2024 19:25
@ccoVeille
Copy link
Contributor Author

Quick follow-up

The directive was used twice in 3 months

https://github.com/search?q=%22editorconfig-checker-disable-next-line%22+-is%3Afork+-org%3Aeditorconfig-checker&type=code

I feel proud 😅

@ccoVeille ccoVeille mentioned this pull request Nov 21, 2024
Closed
This was referenced Jan 5, 2025
Closed
Closed
@editorconfig-checker-bot editorconfig-checker-bot mentioned this pull request Jan 6, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2025
Merged
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 10, 2025
Update module github.com/editorconfig-checker/editorconfig-checker/v3…
98edc27 
…/cmd/editorconfig-checker to v3.1.1 (forgejo) (#6520)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) | minor | `v3.0.3` -> `v3.1.1` |

---

### Release Notes

<details>
<summary>editorconfig-checker/editorconfig-checker (github.com/editorconfig-checker/editorconfig-checker/v3/cmd/editorconfig-checker)</summary>

### [`v3.1.1`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.1.0...v3.1.1)

##### Bug Fixes

-   dockerfile expected binary at /, not /usr/bin/ [#&#8203;410](editorconfig-checker/editorconfig-checker#410) ([#&#8203;411](editorconfig-checker/editorconfig-checker#411)) ([2c82197](editorconfig-checker/editorconfig-checker@2c82197))

### [`v3.1.0`](https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.0)

[Compare Source](editorconfig-checker/editorconfig-checker@v3.0.3...v3.1.0)

##### Features

-   add zip version when compressing all binaries ([#&#8203;321](editorconfig-checker/editorconfig-checker#321)) ([#&#8203;362](editorconfig-checker/editorconfig-checker#362)) ([f1bb625](editorconfig-checker/editorconfig-checker@f1bb625))
-   consolidate adjacent error messages ([#&#8203;360](editorconfig-checker/editorconfig-checker#360)) ([cf4ae1c](editorconfig-checker/editorconfig-checker@cf4ae1c))
-   editorconfig-checker-disable-next-line ([#&#8203;363](editorconfig-checker/editorconfig-checker#363)) ([6116ec6](editorconfig-checker/editorconfig-checker@6116ec6))
-   provide Codeclimate compatible report fromat ([#&#8203;367](editorconfig-checker/editorconfig-checker#367)) ([282c315](editorconfig-checker/editorconfig-checker@282c315))
-   support `.editorconfig-checker.json` config ([#&#8203;375](editorconfig-checker/editorconfig-checker#375)) ([cb0039c](editorconfig-checker/editorconfig-checker@cb0039c))

##### Bug Fixes

-   actually use the correct end marker ([#&#8203;405](editorconfig-checker/editorconfig-checker#405)) ([3c03499](editorconfig-checker/editorconfig-checker@3c03499))
-   add `.ecrc` deprecation warning ([#&#8203;389](editorconfig-checker/editorconfig-checker#389)) ([d33b81c](editorconfig-checker/editorconfig-checker@d33b81c))
-   this release-please marker ([#&#8203;403](editorconfig-checker/editorconfig-checker#403)) ([617c6d4](editorconfig-checker/editorconfig-checker@617c6d4))
-   typo in config, `SpacesAftertabs` => `SpacesAfterTabs` ([#&#8203;386](editorconfig-checker/editorconfig-checker#386)) ([25e3542](editorconfig-checker/editorconfig-checker@25e3542))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTMuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6520
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoludwig theoludwig theoludwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

feat: editorconfig-checker-disable-next-line
3 participants
@ccoVeille @mstruebing @theoludwig