Conditionally define variables b:editorconfig_invoked and b:editorconfig_had_config #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again for this PR! I'd like to finish off #143, then look at this new feature. |
cxw42
requested changes
Apr 2, 2021
|
Thanks, I rebased and made the changes you suggested. |
…g_applied These can be used to introspect whether editorconfig hooks have run for a buffer and whether they had any config to apply in order to make downstream heuristic decisions such as whether to invoke vim-sleuth to guess buffer settings. Resolves editorconfig#141.
cxw42
approved these changes
Apr 4, 2021
There was a problem hiding this comment.
Looks OK to me!
- I squashed your commits into one and adjusted the commit message. I prefer contributors amend commits in response to feedback, rather than adding additional commits. The idea is to make the project's history include only the results of the review, not the process of the review.
- One minor code change.
Thanks very much for your contribution! Please feel free to take a look at the issues list to see if there are any other things you might want to fix ;) . Happy Vimming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be used to introspect whether editorconfig hooks have run for a buffer
and whether they had any config to apply in order to make downstream heuristic
decisions such as whether to invoke vim-sleuth to guess buffer settings.
Resolves #141.