Add the ability to disable EditorConfig per-buffer #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxw42
requested changes
Oct 18, 2020
There was a problem hiding this comment.
Thanks very much for this PR! I have left a few comments suggesting changes.
Before merging, I would like two structural changes. Please:
- In plugin/editorconfig.vim, move the check up to line 205, before "Check if any .editorconfig does exist". If
b:EditorConfig_disableis set, I don't think we need to look for any .editorconfig files. That will make the plugin more responsive onb:EditorConfig_disabled buffers. - Inside the
if b:EditorConfig_disableblock, please add a modified copy of lines 225-228 to tell the user that the buffer is being skipped (ifg:EditorConfig_verboseis set). That will make debugging "why doesn't this work???!" failures substantially easier :D .
Much appreciated!
This would allow users to disable EditorConfig for specific filetypes, or create their own rules for disabling.
midchildan
force-pushed
the
feat/disable-per-buffer
branch
from
2eb40e3
to
d2ff151
Compare
|
Thanks for reviewing! I've pushed a fix. |
cxw42
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a buffer-local variable,
b:EditorConfig_disable, that would allow users to disable EditorConfig for specific filetypes, or create their own rules for disabling.Solves #104.