-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for [No Name] buffers #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this PR! I apologize for the delay in reviewing it. I had COVID earlier this year :( and it has really thrown off my workflow.
I have made some comments that I think will simplify the change. Would you please take a look and let me know your thoughts? Much appreciated!
Good to merge? |
@cxw42 What do you think :) |
@cxw42 kindly reminding you this PR in case you missed it |
@cxw42 LGTM? |
Sorry for the delay --- I have been recovering from a concussion :( . |
@Jorengarenar may I force-push your branch (jorengarenar/master)? In testing this, I have found (1) it needs a rebase/squash, and (2) there are some other bugs --- including applying the current buffer's settings to |
Of course, no problem.
I hope you are feeling better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased onto master
, squashed, and force-pushed. Thanks again!
Windows timed out (#200) --- proceeding with merge! Thanks again for the PR and for your patience! |
Great, thanks! |
Fixes #55