Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limitrange): adding limit range to nauticus #17

Merged
merged 2 commits into from
Jan 29, 2023
Merged

feat(limitrange): adding limit range to nauticus #17

merged 2 commits into from
Jan 29, 2023

Conversation

smileisak
Copy link
Member

Signed-off-by: Ismail KABOUBI ikaboubi@gmail.com

What this PR does / why we need it:

This feature adds limit ranges to Nauticus. The limit range feature in Nauticus allows users to set constraints on the resources that can be requested and consumed by the containers in a namespace. This feature provides an additional layer of control over resource utilization in the cluster, ensuring that high resource-intensive workloads do not affect the performance of other services. To utilize this feature, users can specify limit ranges in their namespace configuration and Nauticus will enforce these limits at runtime. This provides a simple and effective way to manage the resource consumption in a multi-tenant cluster environment.

Closes #8

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

#8

How Has This Been Tested?

Tested manually against a kind cluster. Still working on Tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

Add limit ranges to Nauticus Controller.

@smileisak smileisak self-assigned this Jan 29, 2023
@smileisak smileisak added the enhancement New feature or request label Jan 29, 2023
@smileisak smileisak added this to the Release v0.1.0 milestone Jan 29, 2023
@smileisak smileisak merged commit 0ab84c2 into main Jan 29, 2023
@smileisak smileisak deleted the issue/8 branch January 29, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Limit Range to the space specification
1 participant