Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide status.conditions for Nauticus controller #33

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

smileisak
Copy link
Member

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #27

How Has This Been Tested?

Tested locally with a kind cluster.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • All new and existing tests passed.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • configuration schema change

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

Provide status.conditions for Nauticus controller

@smileisak smileisak self-assigned this Feb 13, 2023
@smileisak smileisak added the enhancement New feature or request label Feb 13, 2023
@smileisak smileisak merged commit 1495cb3 into main Feb 16, 2023
@smileisak smileisak deleted the issue/27 branch February 16, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Ready Condition to Status field
1 participant