Fix an issue with globbing for BAT* when it is not present. On Ubuntu 14... #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 14.04, machines without a battery don't have any BAT* devices, and zsh throws an error instead of passing an empty glob.
|
Thanks for catching this! I don't think that bash supports |
|
I just used a quick find like so...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with globbing for BAT* when it is not present. On Ubuntu 14.04, machines without a battery don't have any BAT* devices, and zsh throws an error instead of passing an empty glob. http://zshwiki.org/home/options/expn has documentation for the null_glob option.
Prior to this change, machines without a battery print
__promptline_battery:27: no matches found: /sys/class/power_supply/BAT*
before each prompt.