Add optional bold to theme colors #30
Conversation
pdf
force-pushed
the
add_optional_bold
branch
2 times, most recently
from
74d3c21
to
bb6cab0
Compare
|
I left the powerlineclone theme update in a separate commit in case you don't want to take it. |
|
Supporting boldness is a good feature. However, I suspect supporting boldness may result in issues, due to the powerline symbols - in my experience, terminals don't like displaying these special symbols with bold. So even if we end up supporting boldness, I don't think the default themes should use it (but it will be easy for users to use bold if they would like to). Terminals typically support setting foreground, background and attributes. Bold is just one of the possible attributes, there are others like Could you modify the PR to handle any attribute (not just bold)? For example, the themes may set |
Adds an optional field to color definitions, that may be set to a comma-separated string containing a combination of the following attributes: - bright (alias: bold) - dim - standout (alias: italic) - underscore (alias: underline) - blink - reverse - hidden - strikeout (alias: strikethrough) When set, the corresponding modifier will be added to the color, to alter text display on supported terminals.
pdf
force-pushed
the
add_optional_bold
branch
from
bb6cab0
to
1a0b0a6
Compare
|
Hello from the future 😉 I have updated the PR to include the following attributes:
And I've removed the commit modifying the promptlineclone theme as requested (though I have not observed any problem displaying bold separator symbols in a handful of terminals). Supporting all the other attributes means having to reset them all individually, which is why I never got around to it originally, but I had to re-generate my prompt, so here it is. |
|
Any chance this can be merged? was looking for this functionality myself. |
|
@edkolev what else would be needed to get this PR merged in? |
Adds an optional field to color definitions, that if set to
'bold'will enablebold foreground text.