New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix git_status ahead/behind counts #68

Open

alphastorm wants to merge 1 commit into edkolev:master from alphastorm:sunil/fix-git-upstream-shorthand

alphastorm commented Oct 30, 2017

This fixes the call to git to retrieve behind_count/ahead_count.

Using the following versions:

git version 2.15.0
zsh 5.4.2 (x86_64-apple-darwin15.6.0)

The current implementation throws an error, but quoting the arguments fixes it:

$ git rev-list --left-right --count @{upstream}...HEAD
fatal: ambiguous argument '@a...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

$ git rev-list --left-right --count "@{upstream}...HEAD"
0	1


          fix git_status ahead/behind counts

88335ba

Author

alphastorm commented Oct 30, 2017

Appears another PR is open for this as well, #31, but that has an unnecessary Fix boolean check on only_if_ssh for host slice commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment