Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-164 - Further revisions to the AssetBackedSecurities ontology are needed #1919

Merged
merged 1 commit into from
May 26, 2023
Merged

SEC-164 - Further revisions to the AssetBackedSecurities ontology are needed #1919

merged 1 commit into from
May 26, 2023

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented May 5, 2023 •
edited
Loading

Signed-off-by: Elisa Kendall ekendall@thematix.com

Description

  1. Cleaned up ABS with respect to bonds that were already defined in the bonds ontology
  2. Added controlled amortization ABS
  3. Added fully amortizing ABS
  4. Moved bond pool from CDOs to ABS

Fixes: #1918 / SEC-164

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
SEC-164 #comment - cleaned up ABS with respect to bonds that were alr…
41efc5c 
…eady defined in the bonds ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added consistency About overall consistency SEC FIBO Securities labels May 5, 2023
@ElisaKendall ElisaKendall self-assigned this May 5, 2023
@ElisaKendall ElisaKendall changed the title SEC-164 - Further revisions to the AssetBackedSecurities ontology are needed (WIP) SEC-164 - Further revisions to the AssetBackedSecurities ontology are needed May 19, 2023
@ElisaKendall ElisaKendall merged commit 3240afb into edmcouncil:master May 26, 2023
@ElisaKendall ElisaKendall deleted the SEC-164 branch May 26, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue tahoeblue approved these changes

@rivettp rivettp Awaiting requested review from rivettp

Assignees

@ElisaKendall ElisaKendall

Labels
consistency About overall consistency SEC FIBO Securities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEC-164 - Further revisions to the AssetBackedSecurities ontology are needed
3 participants
@ElisaKendall @tahoeblue @jfgemski