Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FND-380 - Revise / replace details from the FIBO Documents and Quantities and Units ontologies with their counterparts from the Commons Ontology Library v1.1 #1987

Merged
merged 21 commits into from
Jan 10, 2024
Merged

FND-380 - Revise / replace details from the FIBO Documents and Quantities and Units ontologies with their counterparts from the Commons Ontology Library v1.1 #1987

merged 21 commits into from
Jan 10, 2024

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Jan 3, 2024 •
edited
Loading

Description

  1. Replaced content from the FIBO Documents ontology with the same elements from the Commons 1.1 Documents ontology, deprecating those elements that were replaced.
  2. Replaced content from the FIBO Quantities and Units and Analytics ontologies with the same elements from the Commons 1.1 Quantities and Units ontology

Fixes: #1986 / FND-380

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
FND-380 #comment - integrate the new Commons Documents ontology with …
4507821 
…the FIBO documents ontology and deprecate duplications

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced concepts from the FIBO documents ontology…
9a5ca77 
… with those from the Commons 1.1 documents ontology in BE

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
Merge branch 'master' of https://github.com/edmcouncil/fibo into FND-380
0f9a263
@ElisaKendall
FBD-380 #comment - replaced elements from the FIBO documents ontology…
3c3a87e 
… with their equivalents in Commons in the BP domain area

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced elements from FIBO documents with their e…
2c696dc 
…quivalents in Commons documents from Commons 1.1 in CAE and DER

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - reverted cases where the original property was ret…
54a2ece 
…ained in the FIBO documents ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced terms from FIBO documents with their equi…
fa9aa98 
…valents from OMG Commons in FBC

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replace FIBO documents concepts with their equival…
8da74c6 
…ents in Commons documents in FND

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced elements from FIBO documents with their e…
d1b32eb 
…quivalents from Commons in the Loans ontologies

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced elements from FIBO documents with their e…
02964a5 
…quivalents in Commons documents in SEC

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 - Merge branch 'master' of https://github.com/edmcouncil/fibo …
cdc8ea2 
…into FND-380

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall self-assigned this Jan 3, 2024
@ElisaKendall
FND-380 #comment - corrected annotation caught by hygiene testing
0feea23 
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replace now redundant elements from FIBO Quantitie…
37946f4 
…s and Units and Analytics with their equivalents from the Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FBD-380 #comment - replace now redundant elements with their equivale…
3a11287 
…nts from the Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - correct hygiene issues
48a9719 
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced additional content that was made redundan…
ceef795 
…t by the new ontologies in the Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced remaining redundant elements with their c…
207d584 
…ounterparts from the new Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced redundant ratio value with ratio from the…
a5a6984 
… Commons 1.1 quantities and units ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - revised ontologies to use Expression over Formula …
9fac462 
…where such simplification was appropriate

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - replaced references to refersTo from Relations wit…
080744c 
…h the equivalent property in the Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
FND-380 #comment - revised remaining ontologies to replace the proper…
9cbdf25 
…ty 'refersTo' from Relations with the one from the Documents ontology in the Commons 1.1 library

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title FND-380 - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1 (WIP) FND-380 - Revise / replace details from the FIBO Documents and Quantities and Units ontologies with their counterparts from the Commons Ontology Library v1.1 Jan 9, 2024
@ElisaKendall ElisaKendall merged commit d2e1daa into edmcouncil:master Jan 10, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the FND-380 branch January 10, 2024 19:58
@mereolog mereolog added this to the 2024Q1 FIBO Release milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue tahoeblue approved these changes

@rivettp rivettp Awaiting requested review from rivettp

Assignees

@ElisaKendall ElisaKendall

Labels
Commons Domain enhancement FND FIBO Foundations
Projects
None yet
Milestone
2024Q1 FIBO Release
Development

Successfully merging this pull request may close these issues.

FND-380 - Revise / replace several ontologies with their counterparts from the Commons Ontology Library v1.1
4 participants
@ElisaKendall @tahoeblue @jfgemski @mereolog