-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DER-126 - Need to clean up the hierarchy of swap-related events #1992
Conversation
… level so that it is a direct subclass of derivative instrument Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ded the definition of a fixed-fixed interest rate swap, which was a gap Signed-off-by: Elisa Kendall <ekendall@thematix.com>
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a change not covered by the issue, related to replacing ExchangeRateObvservable (something that needs to change over time) by QuotedExchangeRate (which is a single value). Though ExchangeRateObvservable seems generally mis-defined in a similar way.
<owl:someValuesFrom> | ||
<owl:Restriction> | ||
<owl:onProperty rdf:resource="&fibo-fnd-rel-rel;hasIdentity"/> | ||
<owl:someValuesFrom rdf:resource="&fibo-ind-fx-fx;QuotedExchangeRate"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bigger issue I noticed here, related to the whole definition of RateObservable - it should be something you observe over time not a specific value. However QuotedExchangeRate is defined as "exchange rate quoted at a specific point in time" and indeed that's reflected in its superclass of MarketRate.
Description
Fixes: #1991 / DER-126
Checklist: