Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DER-126 - Need to clean up the hierarchy of swap-related events #1992

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

ElisaKendall
Copy link
Contributor

Description

  1. Moved currency derivative up the class hierarchy a level so that it is a direct subclass of derivative instrument level so that it is a direct subclass of derivative instrument
  2. Simplified / cleaned up the swaps hierarchy and added the definition of a fixed-fixed interest rate swap, which was a gap

Fixes: #1991 / DER-126

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

… level so that it is a direct subclass of derivative instrument

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ded the definition of a fixed-fixed interest rate swap, which was a gap

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added consistency About overall consistency DER FIBO Derivatives labels Jan 16, 2024
@ElisaKendall ElisaKendall self-assigned this Jan 16, 2024
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title DER-126 - Need to clean up the hierarchy of swap-related events (WIP) DER-126 - Need to clean up the hierarchy of swap-related events Jan 23, 2024
DER/RateDerivatives/IRSwaps.rdf Outdated Show resolved Hide resolved
Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a change not covered by the issue, related to replacing ExchangeRateObvservable (something that needs to change over time) by QuotedExchangeRate (which is a single value). Though ExchangeRateObvservable seems generally mis-defined in a similar way.

<owl:someValuesFrom>
<owl:Restriction>
<owl:onProperty rdf:resource="&fibo-fnd-rel-rel;hasIdentity"/>
<owl:someValuesFrom rdf:resource="&fibo-ind-fx-fx;QuotedExchangeRate"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bigger issue I noticed here, related to the whole definition of RateObservable - it should be something you observe over time not a specific value. However QuotedExchangeRate is defined as "exchange rate quoted at a specific point in time" and indeed that's reflected in its superclass of MarketRate.

@ElisaKendall ElisaKendall merged commit 10ee568 into edmcouncil:master Jan 30, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the DER-126 branch January 30, 2024 05:29
@mereolog mereolog added this to the 2024Q1 FIBO Release milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency About overall consistency DER FIBO Derivatives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DER-126 - Need to clean up the hierarchy of swap-related events
5 participants