Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FBC-284 - The definition of Issuer should be adjusted to allow the same issuer to issue more than one #2014

Merged
merged 2 commits into from
May 6, 2024
Merged

FBC-284 - The definition of Issuer should be adjusted to allow the same issuer to issue more than one #2014

merged 2 commits into from
May 6, 2024

Conversation

ElisaKendall
Copy link
Contributor

Description

Better integrated contract principal and counterparty with the overall contract pattern; augmented restrictions on issuer to say that they must issue a contract and revised the definition per notes.

Fixes: #2013 / FBC-284

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
FBC-284 #comment - better integrated contract principal and counterpa…
825acca 
…rty with the overall contract pattern; augmented restrictions on issuer to say that they must issue a contract and revised the definition per notes

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added consistency About overall consistency FND FIBO Foundations FBC FIBO Financial Business and Commerce labels May 4, 2024
@ElisaKendall ElisaKendall self-assigned this May 4, 2024
@ElisaKendall ElisaKendall merged commit dbdd526 into master May 6, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the FBC-284 branch May 6, 2024 20:57
@mereolog mereolog added this to the 2024Q2 FIBO Release milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue tahoeblue approved these changes

Assignees

@ElisaKendall ElisaKendall

Labels
consistency About overall consistency FBC FIBO Financial Business and Commerce FND FIBO Foundations
Projects
None yet
Milestone
2024Q2 FIBO Release
Development

Successfully merging this pull request may close these issues.

FBC-284 - The definition of Issuer should be adjusted to allow the same issuer to issue more than one
4 participants
@ElisaKendall @tahoeblue @jfgemski @mereolog