Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub-2015 - corrected bug for incorrect prefix on hasRole #2017

Merged
merged 1 commit into from
May 6, 2024
Merged

GitHub-2015 - corrected bug for incorrect prefix on hasRole #2017

merged 1 commit into from
May 6, 2024

Conversation

ElisaKendall
Copy link
Contributor

Description

corrected bug for incorrect prefix on hasRole

Fixes: #2015

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
GitHub-2015 - corrected bug for incorrect prefix on hasRole
a938aae 
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added bug FND FIBO Foundations labels May 6, 2024
@ElisaKendall ElisaKendall self-assigned this May 6, 2024
aamedina
aamedina approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@aamedina aamedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I was considering that one too. Thanks for the review and correction.

@ElisaKendall
Copy link
Contributor Author

Aha, I was considering that one too. Thanks for the review and correction.

@aamedina You're welcome. Happy to take other issues you find! Maybe close your pull request n/c when you have a moment :). Best, Elisa

@ElisaKendall ElisaKendall merged commit 23e7fe5 into master May 6, 2024
4 of 5 checks passed
@ElisaKendall ElisaKendall deleted the GitHub-2015 branch May 6, 2024 18:28
@mereolog mereolog added this to the 2024Q2 FIBO Release milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@aamedina aamedina aamedina approved these changes

@mereolog mereolog Awaiting requested review from mereolog

@tahoeblue tahoeblue Awaiting requested review from tahoeblue

Assignees

@ElisaKendall ElisaKendall

Labels
bug FND FIBO Foundations
Projects
None yet
Milestone
2024Q2 FIBO Release
Development

Successfully merging this pull request may close these issues.

fibo-fnd-pty-pty:hasThingInRole owl:equivalentProperty refers to missing cmns-pts:hasRole predicate
4 participants
@ElisaKendall @aamedina @jfgemski @mereolog