-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIBO-138 #52
Merged
trypuz
merged 9 commits into
edmcouncil:master
from
kbalcerek:FIBO-138-Implement-displaying-FIBO-versions-(frontend)
Feb 2, 2021
Merged
FIBO-138 #52
trypuz
merged 9 commits into
edmcouncil:master
from
kbalcerek:FIBO-138-Implement-displaying-FIBO-versions-(frontend)
Feb 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement displaying FIBO versions (frontend) 1. Create drop-down list (above tree on Fibo Viewer page ???) of ontology versions (GET /fibo/ontology/api/) and depending on the selected version, use url value from returned json for rest api endpoint 2. Add query value ?version=BRANCH/TAG to choose ontology version using URL (eg. Business Entities for version=master/2020Q1) 3. Enable authorized (required X-API-Key) users do add/delete instances = add/delete items in drop-down list Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend) open main page for master/2020Q1 version and search ContractsForDifference - you will be redirected to ContractsForDifference ontology in main version (DOES NOT EXIST) instead of ContractsForDifference ontology in master/2020Q1 version (EXIST) Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend) fixed: - master/latest is the default one now, but that may change in the future - there are 2 different URLs for API and it would be good to make it clear: https://spec.edmcouncil.org/fibo/ontology/api/module https://spec.edmcouncil.org/fibo/ontology/master/latest/api/module - now there are 2 different instances for "main" and for "master/latest" version (agree they both have the same content) I suggest adding "DEFAULT" (or something like that) to the top of the list Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
@przemekgradzki , @kbalcerek, any progress here? |
Implement displaying FIBO versions (frontend) - on the "versioned" page AccountingPeriod 'master/2020Q3' clicking the "relationship period qualifier" ("Data model for accounting period" diagram) link will take you to the "non-versioned" RelationshipPeriodQualifier page - should take to "versioned" page Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend) - on page displaying Thing in 'master/2020Q3' version changing version to "master/latest" will take you to master page displaying 'master/latest' version - should take to the page displaying Thing in 'master/latest' version Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement displaying FIBO versions (frontend)
Signed-off-by: Kamil Balcerzak kbalcerek@o2.pl