Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIBO-138 #52

Conversation

kbalcerek
Copy link
Contributor

Implement displaying FIBO versions (frontend)

  1. Create drop-down list (above tree on Fibo Viewer page ???) of ontology versions (GET /fibo/ontology/api/) and depending on the selected version, use url value from returned json for rest api endpoint
  2. Add query value ?version=BRANCH/TAG to choose ontology version using URL (eg. Business Entities for version=master/2020Q1)
  3. Enable authorized (required X-API-Key) users do add/delete instances = add/delete items in drop-down list

Signed-off-by: Kamil Balcerzak kbalcerek@o2.pl

Implement displaying FIBO versions (frontend)
1. Create drop-down list (above tree on Fibo Viewer page ???) of ontology versions (GET /fibo/ontology/api/) and depending on the selected version, use url value from returned json for rest api endpoint
2. Add query value ?version=BRANCH/TAG to choose ontology version using URL (eg. Business Entities for version=master/2020Q1)
3. Enable authorized (required X-API-Key) users do add/delete instances = add/delete items in drop-down list

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
@kbalcerek kbalcerek requested a review from trypuz December 9, 2020 10:26
@trypuz trypuz changed the title FIBO-138 (WIP) FIBO-138 Dec 9, 2020
Implement displaying FIBO versions (frontend)
open main page for master/2020Q1 version and search ContractsForDifference - you will be redirected to ContractsForDifference ontology in main version (DOES NOT EXIST) instead of ContractsForDifference ontology in master/2020Q1 version (EXIST)

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
@trypuz trypuz removed their request for review December 12, 2020 11:14
Implement displaying FIBO versions (frontend)
fixed:
- master/latest is the default one now, but that may change in the future
- there are 2 different URLs for API and it would be good to make it clear:
https://spec.edmcouncil.org/fibo/ontology/api/module
https://spec.edmcouncil.org/fibo/ontology/master/latest/api/module
- now there are 2 different instances for "main" and for "master/latest" version (agree they both have the same content)
I suggest adding "DEFAULT" (or something like that) to the top of the list

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
@trypuz
Copy link
Contributor

trypuz commented Jan 18, 2021

@przemekgradzki , @kbalcerek, any progress here?

Implement displaying FIBO versions (frontend)
- on the "versioned" page AccountingPeriod 'master/2020Q3' clicking the "relationship period qualifier" ("Data model for accounting period" diagram) link will take you to the "non-versioned" RelationshipPeriodQualifier page - should take to "versioned" page

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend)
- on page displaying Thing in 'master/2020Q3' version changing version to "master/latest" will take you to master page displaying 'master/latest' version - should take to the page displaying Thing in 'master/latest' version

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend)
- open ContractsForDifference w 'master/2020Q2' - the tree is not expanding
Description: it happened randomly, tree didn't expand more often on poor network

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend)
- removed unnececery property that caused Warnings

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
Implement displaying FIBO versions (frontend)
- open ontology version without running onto-viewer instance - the version list is too narrow

Signed-off-by: Kamil Balcerzak <kbalcerek@o2.pl>
@trypuz trypuz merged commit 91e0bd5 into edmcouncil:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants