Additional hygiene test for obsolete restrictions #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
…ictions Signed-off-by: mereolog <pawel.garbacz@makolab.com>
…ictions Signed-off-by: mereolog <pawel.garbacz@makolab.com>
…ictions Signed-off-by: mereolog <pawel.garbacz@makolab.com>
mereolog
requested review from
ElisaKendall,
tw-osthus,
Heiner-Oberkampf,
przemekgradzki,
konradkrebs1411 and
stsilva-osthus
|
@merelog - many of these tests have exactly the same comments, even though the tests themselves are slightly different. Would it be possible to refine the comments slightly so that it doesn't look like the tests are duplicates of one another? |
…tions Signed-off-by: mereolog <pawel.garbacz@makolab.com>
I did some refinements - would you mind rechecking them? |
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
Signed-off-by: mereolog <pawel.garbacz@makolab.com>
|
@merelog Much better - thanks! |
ElisaKendall
approved these changes
Jun 24, 2024
tw-osthus
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of tests for obsolete restrictions.