Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add closing </div> tags to HTML snippet #296

Merged
merged 1 commit into from
Oct 6, 2023
Merged

docs: Add closing </div> tags to HTML snippet #296

merged 1 commit into from
Oct 6, 2023

Conversation

mattmazzola
Copy link
Contributor

I was reading through the docs and based on the indentation, it seems the elements that were supposed to contain the error messages from confirm were not closed.

@mattmazzola
Add closing </div> tags to HTML snippet
d7d53b8 
The elements that were supposed to be containing the error messages from `confirm` were not closed.

`<div>{title.error}`
vs
`<div>{title.error}</div>`
edmundhung
edmundhung approved these changes Oct 6, 2023
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edmundhung edmundhung merged commit 9230df3 into edmundhung:main Oct 6, 2023
1 check passed
@mattmazzola mattmazzola deleted the patch-2 branch October 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmazzola @edmundhung