feat(guide): added language switcher dropdown and Japanese language support. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coji
changed the title
coji
force-pushed
the
feature/guide-add-japanese-language-support
branch
from
6fd7e22
to
e68f0cf
Compare
edmundhung
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
Thanks @coji! I just made the logo smaller on desktop so the language switcher can fit in better, but everything else looks good to me!
Personally I would also prefer the language switcher to work before JS, but that might requires changes on the layout so I would leave it as a future improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds language switcher dropdown and Japanese language support to the Conform documentation site.
Key changes:
Updated getMetadata, getFileContent, and getDocPath functions to handle language-specific logic
These changes enable a localized experience for Japanese users within the guide submodule, with the ability to switch between English and Japanese using the language dropdown in the header.