Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getButtonProps types #597

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix: getButtonProps types #597

merged 1 commit into from
Apr 28, 2024

Conversation

lifeiscontent
Copy link
Contributor

closes #514

edmundhung
edmundhung approved these changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I broke the types for array but this is definitely an improvement over what we have. LGTM

@edmundhung edmundhung merged commit 3924d70 into edmundhung:main Apr 28, 2024
2 checks passed
@lifeiscontent lifeiscontent deleted the fix/get-button-props branch May 7, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insert defaultValue is not typed if field is a nullable or optional array
2 participants
@lifeiscontent @edmundhung