fix: FormValue should never be null
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7aae87a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aaronadamsCA
changed the title
FormValue should never be nullFormValue should never be null
edmundhung
force-pushed
the
minor-type-fix
branch
from
94b6a8d
to
3f7fbfa
Compare
edmundhung
force-pushed
the
minor-type-fix
branch
from
3f7fbfa
to
7aae87a
Compare
|
commit: @conform-to/dom
@conform-to/react
@conform-to/validitystate
@conform-to/yup
@conform-to/zod
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I made a mistake in #508 when I widened
FormValueto includenullin some cases. I'm reasonably confident a field'sinitialValuewill never benull.I noticed this when I created a component that takes
name: FieldName<string | object>. You can see the strange behaviour here:TypeScript Playground
You can see what happened when I ran
git blamehere:Since this is a one-line change, I'm just submitting it through the GitHub UI to confirm the tests will pass.