Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Shadn Switch Component example by Using control.value #721

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

reborn2135
Copy link
Contributor

Summary

This PR optimizes the Switch component in the shadcn example by replacing meta.value with control.value. This change aims to improve performance by reducing unnecessary re-renders.

Changes Made

Updated the Switch component to use control.value instead of meta.value
Modified the relevant code snippet as follows:

Copy// Before
checked={meta.value === "on"}

// After
checked={control.value === "on"}

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 41cedcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edmundhung edmundhung merged commit a5e5e65 into edmundhung:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants