-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conform-zod): bigint coercion support #726
feat(conform-zod): bigint coercion support #726
Conversation
🦋 Changeset detectedLatest commit: 43ed549 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
428e174
to
f2aed72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The changes for BigInt makes sense to me but maybe we should keep the number coercion untouched.
Can you help adding some tests for BigInt?
f2aed72
to
790c192
Compare
@edmundhung fixed |
3698934
to
9b5f6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
9b5f6ad
to
e4ceab9
Compare
More templates
@conform-to/dom
@conform-to/react
@conform-to/validitystate
@conform-to/yup
@conform-to/zod
commit: |
this change follows the same pattern as how booleans are coerced.
it also fixes issues with BigInt where if the value is not of a convertable value it doesn't break the app because BigInt/Symbol throw unlike the rest of the type constructors.