Update go version to 1.21 as 1.18 is causing issue in AppendUint32 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devel update
Devel update
Devel update
Devel update
Update golangci-lint.yml
… Also fixed lint issues by updating required packages
edoardottt
requested changes
Oct 14, 2023
|
@edoardottt Updated to 1.21 version. Let's try using this version. Otherwise, I found another issue(golang/go#61851) in which it is mentioned that 1.20 worked fine. If this fails, I can update to that. |
edoardottt
reviewed
Oct 14, 2023
edoardottt
reviewed
Oct 14, 2023
edoardottt
changed the title
|
@edoardottt version updated for golangci-lint. |
edoardottt
requested changes
Oct 14, 2023
| @@ -18,7 +18,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.17 | |||
| go-version: 1.21 | |||
There was a problem hiding this comment.
golangci-lint is failing, I guess is related to this golangci/golangci-lint#3933 (comment)
There was a problem hiding this comment.
Updated golangci-lint to 1.54.2. This seems to work as per golangci/golangci-lint#3107 (comment)
|
Updated golangci-lint to 1.54.2. This seems to work as per golangci/golangci-lint#3107 (comment) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #90 - Updated go version to 1.21.3 as 1.18 is causing issue in AppendUint32.…
Also fixed lint issues by updating required packages