-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON lines output #106
Conversation
Hi @ocervell ! Thank you so much for the PR, really appreciated! I will review the changes when there'll be no errors and zero conflicts (and some free time oc 😭, ask anything) |
@edoardottt Thanks ! Should be good now, updated with devel branch, if you can re-run the tests that would be amazing ;) |
The linter is showing some errors, I use golangci-lint to maintain a good code level. If you need help ask me :) |
@edoardottt should be ready for review / merge ;) BTW, would be nice to update the README for install steps, for me only this worked from the main directory:
Simply running |
Sorry Olivier but I'm writing the thesis these days and I'm super busy. Whenever I find enough time to review the code i will get back to u, I promise it won't take so much. If you want in the meanwhile you can push some test cases to test the functions added (for example GetJSONString with fake colly responses, secrets and so on to see if all the checks are implemented... fields or headers missing, weird data, edge case scenarios.. whatever in your mind). Regarding install steps..
|
Try running:
and appreciate beautiful JSON output ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @ocervell for your amazing work. really appreciated. I'm going to open new issues as I have found some problems to be solved (my fault aha) |
This adds JSON lines support to cariddi, to match with similar tools (ffuf, gau, gospider, etc...).
Usage:
Example output:
Some other changes, so that the output is parseable with jq, such as
cariddi -json | jq '.'
:httpx
)-json
is active: only JSON lines should be returned, no additional textFixes: