fix: update type of some field of Project struct to match response from deps.dev API #71
Conversation
|
Hi @zaibon. I've changed the base form main to devel. There are some conflicts that need to be resolved. |
zaibon
force-pushed
the
project-types
branch
3 times, most recently
from
1b2c788 to
38276d9
Compare
|
@edoardottt Thanks, I've didn't see the devel branch. So I've rebased on it and fixed the conflict. |
…om deps.dev API fixes edoardottt#70
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var ( | ||
| api = depsdev.NewV3API() | ||
| ) | ||
|
|
||
| func TestGetProject(t *testing.T) { |
There was a problem hiding this comment.
Unreliable. If someone stars the repo or fork it the test will fail
There was a problem hiding this comment.
Make sense, I've updated the test to skip comparing actual value.
| OpenIssuesCount string `json:"openIssuesCount,omitempty"` | ||
| StarsCount string `json:"starsCount,omitempty"` | ||
| ForksCount string `json:"forksCount,omitempty"` | ||
| OpenIssuesCount int `json:"openIssuesCount,omitempty"` |
There was a problem hiding this comment.
It would be better to change all the occurences of this issue. For example,
depsdev/pkg/depsdev/project.go
Line 53 in d19b20c
What do you think?
There was a problem hiding this comment.
references: https://docs.deps.dev/api/v3/
There was a problem hiding this comment.
I've added some other type fixe I could find. Any other I've missed?
fixes #70